[
https://issues.apache.org/jira/browse/SOLR-716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625047#action_12625047
]
Shalin Shekhar Mangar commented on SOLR-716:
--------------------------------------------
Oh no, no problem here. Interfere is the wrong word -- more eyes and hands can
only help :)
I only wanted to understand how it helps since I haven't used multiple cores a
lot.
The patch looks good, some comments:
# Why is the public constructor of CoreContainer made package private?
# Can we remove the properties parameter in CoreContainer#evalExpressions. It
is confusing to call this method with two properties instances.
# Note that the way you create coreProperties in CoreContainer#create(SolrCore)
method, the implicit properties are set *after* SolrConfig is created. Unless
I'm misunderstanding something, you will not be able to use the
implicit/automatic properties in your solrconfig.xml.
# Can you please help me understand what this bit of code in
CoreContainer#persist is doing?
{code}
// restore the core expr name if it was one and has not changed
String cname = StrUtils.join(aliases, ',');
Map<String,String> pcore = dcore.getCoreExpressions();
if (pcore != null) {
String namex = pcore.get(null);
if (namex != null) {
String namev = DOMUtil.substituteProperty(namex,
loader.getProperties());
if (namev != null && namev.equals(cname))
cname = namex;
}
}
{code}
> Support properties in configuration files
> -----------------------------------------
>
> Key: SOLR-716
> URL: https://issues.apache.org/jira/browse/SOLR-716
> Project: Solr
> Issue Type: New Feature
> Affects Versions: 1.3
> Reporter: Shalin Shekhar Mangar
> Assignee: Shalin Shekhar Mangar
> Fix For: 1.3
>
> Attachments: solr-716.patch, SOLR-716.patch, SOLR-716.patch
>
>
> Initially suggested by Hoss at
> https://issues.apache.org/jira/browse/SOLR-350?focusedCommentId=12562834#action_12562834
> and taken forward by Henri in SOLR-646
> # Allows users to define global as well as core-specific properties in
> solr.xml which can be used in solrconfig.xml and schema.xml
> {code:xml}
> <solr persistent="false">
> <property name="var" value="value" />
> <cores adminPath="/admin/cores">
> <core name="core0" instanceDir="core0">
> <property name="var" value="value" />
> </core>
> <core name="core1" instanceDir="core1" />
> </cores>
> </solr>
> {code}
> # The following core-specific properties will be added automatically:
> ** solr.core.instanceDir
> ** solr.core.name
> ** solr.core.configName
> ** solr.core.schemaName
> # The variable substitution will be done in this fall-back order --
> core-specific, implicit, global, system properties.
> # The properties defined in solr.xml should also be persisted back as is
> (without evaluation).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
