[
https://issues.apache.org/jira/browse/SOLR-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12627476#action_12627476
]
Yonik Seeley commented on SOLR-743:
-----------------------------------
bq. they are represented by a long and set operations are done with bitwise
arithmetic
Internally, it's done with bitwise arithmetic... but there is a lot of
surrounding/supporting code that will take much longer to execute.
bq. I buy Josh Blochs arguments that the bitset is better left behind in favor
of the enum
As a general rule, perhaps, but advice like this has to be taken in the context
of the broad java dev world. The majority of Java developers out there are
building specific biz apps that one can either say meet or don't meet
performance targets. If those targets aren't met, then they can profile and
find the problem spot. Library and framework developers are a bit different
IMO and the complexity / performance tradeoff shifts. I bet you won't see any
of the internal native bitvectors in the Java class libraries switching to
EnumSet.
> Update the bitset usage in Schema to enums
> ------------------------------------------
>
> Key: SOLR-743
> URL: https://issues.apache.org/jira/browse/SOLR-743
> Project: Solr
> Issue Type: Improvement
> Reporter: Mark Miller
> Priority: Minor
> Fix For: 1.4
>
> Attachments: SOLR-743.patch, SOLR-743.patch
>
>
> For all of the reasons given by smarter people than I (specifically,
> Effective Java), and because its just easier to follow.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
