[ 
https://issues.apache.org/jira/browse/SOLR-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629147#action_12629147
 ] 

David Smiley commented on SOLR-743:
-----------------------------------

Although it is slower (which doesn't surprise me), does it really matter?
I think it's a shame to still use the ancient techniques of an int bitset.  
I've been cringing as I look over this code lately.  Since the code is already 
written and it is admittedly faster... there isn't a strong motivation to 
switch it.  But if it hadn't been written yet, I would be hard put to use an 
int bitset unless I knew an EnumSet would be a bottleneck (and I wouldn't).

> Update the bitset usage in Schema to enums
> ------------------------------------------
>
>                 Key: SOLR-743
>                 URL: https://issues.apache.org/jira/browse/SOLR-743
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Mark Miller
>            Priority: Minor
>             Fix For: 1.4
>
>         Attachments: SOLR-743.patch, SOLR-743.patch
>
>
> For all of the reasons given by smarter people than I (specifically, 
> Effective Java), and because its just easier to follow.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to