[
https://issues.apache.org/jira/browse/SOLR-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12627552#action_12627552
]
Mark Miller commented on SOLR-743:
----------------------------------
bq. As a general rule, perhaps, but advice like this has to be taken in the
context of the broad java dev world. The majority of Java developers out there
are building specific biz apps that one can either say meet or don't meet
performance targets. If those targets aren't met, then they can profile and
find the problem spot. Library and framework developers are a bit different IMO
and the complexity / performance tradeoff shifts. I bet you won't see any of
the internal native bitvectors in the Java class libraries switching to EnumSet.
His advice, from my read, is that the performance penalty is small enough so
that you can clearly say, there is no reason to use the bitset. Thats how I
read it anyway. The performance measurements you gave refute that - if those
numbers are accurate, at most, you can say, in general use enum, for
performance spots you still should be looking at bitsets. Bloch says, drop the
bitset, the performance loss is easily outweighed unqualified. With those
losses, I easily agree with you that the performance loss is not outweighed
(not even close?) - in addition, we are not doing something special - we are
doing a classic case, with classic code. Thats why I still suspect maybe i have
missed somewhere that is not doing bits, though I was pretty thorough in my
check...
> Update the bitset usage in Schema to enums
> ------------------------------------------
>
> Key: SOLR-743
> URL: https://issues.apache.org/jira/browse/SOLR-743
> Project: Solr
> Issue Type: Improvement
> Reporter: Mark Miller
> Priority: Minor
> Fix For: 1.4
>
> Attachments: SOLR-743.patch, SOLR-743.patch
>
>
> For all of the reasons given by smarter people than I (specifically,
> Effective Java), and because its just easier to follow.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
