[
https://issues.apache.org/jira/browse/SOLR-1602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12796285#action_12796285
]
Ryan McKinley commented on SOLR-1602:
-------------------------------------
In an effort to get some resolution here...
There are only three options:
A. Leave it as is
B. Refactor *with* deprecations
--C. Refactor without deprecations--
C is out, so A and B are the only options worth discussing.
The advantage of B is that the package:
o.a.s.response would be clean and organized
(but o.a.s.request would still have a bunch of deprecated files)
The arguments for A amount to: "things are fine as they are", or "the confusion
of changing is not worth whatever slight gain we would get"
The strong resistance is to 'C', I suspect wider ambivalence towards 'B'
> Refactor SOLR package structure to include o.a.solr.response and move
> QueryResponseWriters in there
> ---------------------------------------------------------------------------------------------------
>
> Key: SOLR-1602
> URL: https://issues.apache.org/jira/browse/SOLR-1602
> Project: Solr
> Issue Type: Improvement
> Components: Response Writers
> Affects Versions: 1.2, 1.3, 1.4
> Environment: independent of environment (code structure)
> Reporter: Chris A. Mattmann
> Assignee: Noble Paul
> Fix For: 1.5
>
> Attachments: SOLR-1602.Mattmann.112509.patch.txt,
> SOLR-1602.Mattmann.112509_02.patch.txt, upgrade_solr_config
>
>
> Currently all o.a.solr.request.QueryResponseWriter implementations are
> curiously located in the o.a.solr.request package. Not only is this package
> getting big (30+ classes), a lot of them are misplaced. There should be a
> first-class o.a.solr.response package, and the response related classes
> should be given a home there. Patch forthcoming.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
