[
https://issues.apache.org/jira/browse/SOLR-1602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12797123#action_12797123
]
Chris A. Mattmann edited comment on SOLR-1602 at 1/6/10 2:48 PM:
-----------------------------------------------------------------
Hi All:
In the interest of moving forward on this, I'll go with option B, as I think
I've made my point (as have others) and this is something important to get
wrapped up IMO. I'd like to have an understanding though that in the next
release of SOLR (1.6?) the deprecated classes can go away. Or, as Uri and
Patrick pointed out, if the release cycle picks up then at worst 1.7.
Thanks to everyone for their thoughtful comments. I am going to throw up a new
patch that:
1. replaces the content of all o.a.s.request.\*ResponseWriters with the extends
notation that Ryan mentioned above. In addition, I'll throw in a log message
(to satisfy Erik's concern) in the constructor of each of the deprecated
classes stating that these classes are going away very soon, so please change
references to o.a.s.response.\*
2. adds the old o.a.s.request.\*ResponseWriters to
o.a.s.response.\*ResponseWriters
3. merges with my existing patch which updates references everywhere else
including solrconfig.xml.
I think that should satisfy everyone. I'll throw up a patch hopefully by the
end of the week.
Cheers,
Chris
was (Author: chrismattmann):
Hi All:
In the interest of moving forward on this, I'll go with option B, as I think
I've made my point (as have others) and this is something important to get
wrapped up IMO. I'd like to have an understanding though that in the next
release of SOLR (1.6?) the deprecated classes can go away. Or, as Uri and
Patrick pointed out, if the release cycle picks up then at worst 1.7.
Thanks to everyone for their thoughtful comments. I am going to throw up a new
patch that:
1. replaces the content of all o.a.s.request.*ResponseWriters with the extends
notation that Ryan mentioned above. In addition, I'll throw in a log message
(to satisfy Erik's concern) in the constructor of each of the deprecated
classes stating that these classes are going away very soon, so please change
references to o.a.s.response.*
2. adds the old o.a.s.request.*ResponseWriters to
o.a.s.response.*ResponseWriters
3. merges with my existing patch which updates references everywhere else
including solrconfig.xml.
I think that should satisfy everyone. I'll throw up a patch hopefully by the
end of the week.
Cheers,
Chris
> Refactor SOLR package structure to include o.a.solr.response and move
> QueryResponseWriters in there
> ---------------------------------------------------------------------------------------------------
>
> Key: SOLR-1602
> URL: https://issues.apache.org/jira/browse/SOLR-1602
> Project: Solr
> Issue Type: Improvement
> Components: Response Writers
> Affects Versions: 1.2, 1.3, 1.4
> Environment: independent of environment (code structure)
> Reporter: Chris A. Mattmann
> Assignee: Noble Paul
> Fix For: 1.5
>
> Attachments: SOLR-1602.Mattmann.112509.patch.txt,
> SOLR-1602.Mattmann.112509_02.patch.txt, upgrade_solr_config
>
>
> Currently all o.a.solr.request.QueryResponseWriter implementations are
> curiously located in the o.a.solr.request package. Not only is this package
> getting big (30+ classes), a lot of them are misplaced. There should be a
> first-class o.a.solr.response package, and the response related classes
> should be given a home there. Patch forthcoming.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
