[
https://issues.apache.org/jira/browse/SOLR-1602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12797524#action_12797524
]
Erik Hatcher commented on SOLR-1602:
------------------------------------
Noble - thanks for mentioning the solr.* trick. I thought of this the other
day. It's kinda already done, no?
from SolrResourceLoader
static final String[] packages =
{"","analysis.","schema.","handler.","search.","update.","core.","request.","update.processor.","util.",
"spelling.", "handler.component.", "handler.dataimport."};
So, with the response package registered in there, all would be fine. I still
think the right thing to do with this one is simply to deprecate and sweep it
up after a version released or so. Can't hurt really.
This actually gets to some package design considerations. While it has been
frustrating for some Lucene hackers to hit the wall on final/private classes in
the core, it gave Lucene a lot of flexibility to refactor relentlessly without
worrying about deprecating and leaving a mess. But if things are public actual
API meant to be extended, deprecation is the kindest, most appropriate way
forward.
> Refactor SOLR package structure to include o.a.solr.response and move
> QueryResponseWriters in there
> ---------------------------------------------------------------------------------------------------
>
> Key: SOLR-1602
> URL: https://issues.apache.org/jira/browse/SOLR-1602
> Project: Solr
> Issue Type: Improvement
> Components: Response Writers
> Affects Versions: 1.2, 1.3, 1.4
> Environment: independent of environment (code structure)
> Reporter: Chris A. Mattmann
> Assignee: Noble Paul
> Fix For: 1.5
>
> Attachments: SOLR-1602.Mattmann.112509.patch.txt,
> SOLR-1602.Mattmann.112509_02.patch.txt, upgrade_solr_config
>
>
> Currently all o.a.solr.request.QueryResponseWriter implementations are
> curiously located in the o.a.solr.request package. Not only is this package
> getting big (30+ classes), a lot of them are misplaced. There should be a
> first-class o.a.solr.response package, and the response related classes
> should be given a home there. Patch forthcoming.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
