[ 
https://issues.apache.org/jira/browse/SOLR-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12840014#action_12840014
 ] 

Hoss Man commented on SOLR-1743:
--------------------------------

No worries dude .. i don't really even understand how it worked before, let 
alone with your patch.

Your latest version deals with my typo in schema.xml example, but when testing 
out some other use cases it looks like the default assumption was that 
abortOnConfigurationError=true unless the solrconfig.xml can be parsed cleanly 
and sets it to false ... which means that in 1.4 a single core malformed 
solrconfig.xml (ie: garbage in the prolog) would generate a good error message 
-- and with your latest patch it still generates the "missind core name" error.

It seems like in order to preserve we need to use tertiary state for the 
CoreContainer.abortOnConfigurationError ... null assumes true until at least 
one solrocnfig.xml is parsed cleanly, then false unless at least one config 
sets it to true.

I'm also wondering if your patch breaks the purpose of 
CoreContainer.Initializer.setAbortOnConfigurationError ... i think the idea 
there was that prior to initializing the CoreContainer, Embedded Solr users 
could call that method to force abortOnConfigurationError even if it wasn't set 
in any of hte solrconfig.xml files.


> error reporting is rendering "404 missing core name in path" for all type of 
> errors
> -----------------------------------------------------------------------------------
>
>                 Key: SOLR-1743
>                 URL: https://issues.apache.org/jira/browse/SOLR-1743
>             Project: Solr
>          Issue Type: Bug
>          Components: Build
>         Environment: all
>            Reporter: Marcin
>            Assignee: Mark Miller
>             Fix For: 1.5
>
>         Attachments: SOLR-1743.patch, SOLR-1743.patch, SOLR-1743.patch
>
>
> despite the error in schema syntax or any other type of error you will always 
> get:
> "404 missing core name in path" communicate.
> cheers,
> /Marcin

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to