Pushed as series of patches ending last of which is 201b52db45f9c7f10b159bbbcb8d41b1b9fc6f2d. -- Matej Kollar Satellite Engineering, Red Hat
----- Original Message ----- > From: "Maximilian Meister" <mmeis...@suse.de> > To: spacewalk-devel@redhat.com > Sent: Tuesday, January 28, 2014 11:45:14 AM > Subject: Re: [Spacewalk-devel] [PATCH] Adding a password strength meter to > spacewalk > > On 01/24/2014 12:29 PM, Matej Kollar wrote: > > Hi everybody, > > here you can find the new patch with the following changes: > > > Hi Maximilian. > > > > I see you have made some nice work there but there are still few things > > that need to be fixed. > > > > * Warning pop-up. > > * Could it be moved to the right or bottom of the filed? > > * It also blinks/flickers on change, is there a way to stop it? > > > > * Colored progress bar/strength meter. > > * It is connected with the password field in very strange way > > (visually). > > Would it be possible to change it as per Michael's suggestion > > to look like [1] or [2]? Personally I would prefer second option. > > * progress bar now has its own named column > > > > > * Spec > > * `jquery.pwstrength.bootstrap` is not good name for package. I > > suggest > > `pwstrength-bootstrap` (the .spec is called such anyway). > > * package name == filename > > > * `Source0` is defined in a bit complicated way. Using > > [4] would not only be sufficient but will make it clearer and > > easier to understand. > > Source0 is now readable :) as in [4] > > > > > * Is there simple way to change rules that determine what is acceptable > > password? > > * E.g. various "character classes" reminded me > > there are other ways to make good password :-). [3] > > > > Thanks for the effort invested and keep up good work :-). > > > > [1] > > http://www.jqueryscript.net/demo/Simple-jQuery-Password-Strength-Indicator-Plugin-passMeter/ > > [2] > > http://cdn1.freshdesignweb.com/wp-content/uploads/2011/09/jquery-password-strength-meter-005.jpg > > [3] http://xkcd.com/936/ > > [4] > > https://github.com/ablanco/jquery.pwstrength.bootstrap/archive/1.0.2.tar.gz > > > > > > please check it out, and tell me if I missed something. > > Thank you > Maximilian > > -- > -- > Mit freundlichen Grüßen, > Maximilian Meister > Systems Management Department > > SUSE LINUX Products GmbH > Maxfeldstr. 5 > D-90409 Nuremberg, Germany > > http://www.suse.com > > GF: Jeff Hawn, Jennifer Guild, Felix Imendoerffer, HRB 21284 (AG Nuremberg) > > > _______________________________________________ > Spacewalk-devel mailing list > Spacewalk-devel@redhat.com > https://www.redhat.com/mailman/listinfo/spacewalk-devel _______________________________________________ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
