-- Matej Kollar Satellite Engineering, Red Hat
----- Original Message ----- > From: "Maximilian Meister" <mmeis...@suse.de> > To: spacewalk-devel@redhat.com > Sent: Friday, January 24, 2014 2:33:46 PM > Subject: Re: [Spacewalk-devel] [PATCH] Adding a password strength meter to > spacewalk > > On 01/24/2014 12:29 PM, Matej Kollar wrote: > > > > * Warning pop-up. > > * Could it be moved to the right or bottom of the filed? > Yes. Though on the bottom it overlaps with the bar, and on the right it > could end up being > compressed, depending on the window size of your browser. > I guess I could try to "hang" the popover on the bottom of the bar for > example. > Right now it's attached to the input field, which makes sense IMO. > So I personally would keep it on top, what do you think? > > * It also blinks/flickers on change, is there a way to stop it? > The popover needs to be destroyed and recreated to update it, otherwise > it stacks up > in the html output. That's where the flickering comes from. > I am currently not aware of a workaround. The popover class has the methods > show, hide, toggle and destroy. > > > > * Colored progress bar/strength meter. > > * It is connected with the password field in very strange way > > (visually). > > Would it be possible to change it as per Michael's suggestion > > to look like [1] or [2]? Personally I would prefer second option. > I guess I could give it an extra column like in [2] and place it under the > Confirm Password: field? > > > > * Spec > > * `jquery.pwstrength.bootstrap` is not good name for package. I > > suggest > > `pwstrength-bootstrap` (the .spec is called such anyway). > I will rename it. > > * `Source0` is defined in a bit complicated way. Using > > [4] would not only be sufficient but will make it clearer and > > easier to understand. > Agreed. I took a hint at https://fedoraproject.org/wiki/Packaging:SourceURL > But I can change it as you said. Appreciate that you looked up some recommendations. However, the document you mention states: "If the upstream does not create tarballs for releases, you can use this mechanism to produce them" But upstream does create the tarball... [4]. Just saying ;-). > > > > * Is there simple way to change rules that determine what is acceptable > > password? > > * E.g. various "character classes" reminded me > > there are other ways to make good password :-). [3] > > > [3] = Nice :) I couldn't imagine that yet... > Yesterday the maintainer of that project also opened an issue: > https://github.com/ablanco/jquery.pwstrength.bootstrap/issues/14 > which points exactly to that illustration, so maybe soon there'll be > support for that. > > > -- > -- > Mit freundlichen Grüßen, > Maximilian Meister > Systems Management Department > > SUSE LINUX Products GmbH > Maxfeldstr. 5 > D-90409 Nuremberg, Germany > > http://www.suse.com > > GF: Jeff Hawn, Jennifer Guild, Felix Imendoerffer, HRB 21284 (AG Nuremberg) > > _______________________________________________ > Spacewalk-devel mailing list > Spacewalk-devel@redhat.com > https://www.redhat.com/mailman/listinfo/spacewalk-devel _______________________________________________ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
