On Sat, 19 Oct 2002, Edouard Gomez wrote:
Hopefully this makes more sense.
>
> Hello,
>
> I merged the experimental patch for pppoe support in pppoa3. At the
> moment the code is for linux only as i don't have *BSD box.
>
> I would like people who needs or can use PPPoE to try this patch.
>
I don't think I can - can BT people use PPPoE?
> Index: src/pppoa3.c
> ===================================================================
> RCS file: /cvsroot/speedtouch/speedtouch/src/pppoa3.c,v
> retrieving revision 1.25
> diff -r1.25 pppoa3.c
> 915a970,972
> > #ifdef __linux__
> > if(write_dest(fdout, destination_buf, n +
>(bridging)?-BRIDGING1483_HEADER:HDLC_HEADER_SIZE) > 0)
This is surely wrong? ITYM
if(write_dest(fdout, destination_buf, n +
((bridging)?-BRIDGING1483_HEADER:HDLC_HEADER_SIZE)) > 0)
Infact I'm amazed it works at all as you will be passing a negative length to
write_dest.
> 1166a1227,1247
> > #ifdef __linux__
> > if(bridging) {
> > /*
> > * When bridging aal5 frames will never use more than 1500
>bytes
> > * because max I802.2 frames are 15000 bytes long, so there is
>no
Do you mean 1500 here in the comment rather than 15000. Otherwise it doesn't make
sense!
> > * buffer overflow possible here even if we use 12 bytes more
> > */
> >
> 1193a1275,1277
> > #ifdef __linux__
> > return(r + (bridging)?BRIDGING1483_HEADER:-HDLC_HEADER_SIZE);
Wrong? ITYM
return(r + ((bridging)?BRIDGING1483_HEADER:-HDLC_HEADER_SIZE));
--
God said, "div D = rho, div B = 0, curl E = - @B/@t, curl H = J + @D/@t,"
and there was light.
http://tjw.hn.org/ http://www.locofungus.btinternet.co.uk/
Liste de diffusion modem ALCATEL SpeedTouch USB
Pour se désinscrire : mailto:speedtouch-request@;ml.free.fr?subject=unsubscribe
