On Thu, 20 Nov 2003, Leonard den Ottolander wrote:

>                               /* calculate the rest if there is any */
> -                             num_bytes_new = num_bytes_read - 
> nb_cells*ATM_CELL_TOTAL_SIZE;
> -                             num_bytes_read -= nb_cells*ATM_CELL_TOTAL_SIZE;
> +                             num_bytes_new = num_bytes_read -= nb_cells * 
> ATM_CELL_TOTAL_SIZE;
>  
It's a style thing but this I really don't like. It is far too easy
to overlook the - in the -= in the changed version. IMnsHO, the
original was better.

Wouldn't
num_bytes_read -= nb_cells * ATM_CELL_TOTAL_SIZE;
num_bytes_new = num_bytes_read;
be better?

Tim.

-- 
God said, "div D = rho, div B = 0, curl E = - @B/@t, curl H = J + @D/@t," 
and there was light.

     http://tjw.hn.org/      http://www.locofungus.btinternet.co.uk/



Liste de diffusion modem ALCATEL SpeedTouch USB
Pour se désinscrire : mailto:[EMAIL PROTECTED]

        

Reply via email to