On Sun, Jun 5, 2011 at 09:54, Baruch Siach <bar...@tkos.co.il> wrote: > On Sun, Jun 05, 2011 at 01:13:28PM +0530, Jassi Brar wrote: >> On Sun, Jun 5, 2011 at 12:48 PM, Grant Likely <grant.lik...@secretlab.ca> >> wrote: >> > [repost: I had a typo on the spi-devel-general mailing list address] >> > >> > Sort the SPI makefile and enforce the naming convention spi_*.c for >> > spi drivers. > > [snip] > >> Though the spi_ prefix seems redundant considering the files are in >> 'spi' directory. >> Just a thought, no objection. > > When looking at the list of loaded modules (e.g. in an Oops message), the name > "spi_xilinx" is much more meaningful than just "xilinx", for example.
Plus, when dropping the prefix, spi_xilinx.ko and gpio-xilinx.ko become the same... So now we have spi_<name>.c (with underscore) and gpio-<name>.c (with dash)? And other subsystems go with <name>-<type>.c instead, e.g. drivers/mfd/wm831x-spi.c? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ------------------------------------------------------------------------------ Simplify data backup and recovery for your virtual environment with vRanger. Installation's a snap, and flexible recovery options mean your data is safe, secure and there when you need it. Discover what all the cheering's about. Get your free trial download today. http://p.sf.net/sfu/quest-dev2dev2 _______________________________________________ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general