there is a sys.exit() that I added at Grig's request at the end of testbase.py; its testbase.py's main() method that runs the actual tests in all cases. the result code is determined by unittest's result.wasSuccessful(). it was working when i first implemented it, maybe you can help track down why its not returning.
On Mar 14, 2007, at 10:30 PM, [EMAIL PROTECTED] wrote: > > Some of you may know that I run a Python buildbot for SQLAlchemy: > > http://www.python.org/dev/buildbot/community/all/?show=g5%20OSX% > 20trunk&show=g5%20OSX%202.5 > > It always shows "build successful" even though there are plenty of > actual > test failures on my Mac. After letting it languish for a long time > I dug > into the problem a bit this evening. It seems that SQLAlchemy's > test script > (test/alltests.py) doesn't exit with any indication of success or > failure. > Consequently, it appears to always succeed. > > I'm not much of a unittest module person, but it appears the > unittest.TextTestRunner class is a fundamental barrier to extracting a > useful error code from the tests. Its run() method doesn't seem to > return > anything useful, at least nothing that's documented. I suppose the > simplest > hack would be to temporarily replace sys.stderr with a StringIO > object when > running the test, rummage around in it looking for "failures=NN, > errors=MM", > restore sys.stderr, dump the output, then exit with NN+MM. I could > also > replace test/alltests.py with something of my own invention but I'd > prefer > to rely as much as possible on the test setup presented by the SQA > distribution. > > Skip > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "sqlalchemy" group. To post to this group, send email to sqlalchemy@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/sqlalchemy?hl=en -~----------~----~----~----~------~----~------~--~---
