its line 289 of compiler.py def visit_typeclause(self, typeclause, **kwargs): return typeclause.type.dialect_impl(self.dialect, _for_ddl=True).get_col_spec()
if "type" subclasses Text, there should be no warning On Jan 8, 2008, at 10:51 PM, Rick Morrison wrote: > I guess I'm being dense: I don't see it. > > Here is what I think is doing the inheritence From mssql.py line 191- > ish: > > class MSText(sqltypes.Text): > def get_col_spec(self): > if self.dialect.text_as_varchar: > return "VARCHAR(max)" > else: > return "TEXT" > > it currently uses no dialect_impl() override. > > and then on line 366: > > class MSSQLDialect( default.DefaultDialect): > colspecs = { > sqltypes.Unicode : MSNVarchar, > ... > sqltypes.String : MSString, > sqltypes.Text : MSText, > ... > } > > > > > On Jan 8, 2008 10:27 PM, Michael Bayer <[EMAIL PROTECTED]> > wrote: > it has to do with what the string/text types in mssql.py inherit - > if you inherit String you get the warning, if Text/TEXT, you dont. > just look inside of dialect_impl(). > > > On Jan 8, 2008, at 8:28 PM, Rick Morrison wrote: > >> I still get this on r4031 with MSSQL/pymssql. Are there changes >> that need to be made in the database module, maybe? Far as I can >> see all my Table() defs use the TEXT type identifier. >> >> On Jan 8, 2008 4:36 AM, Felix Schwarz < [EMAIL PROTECTED]> wrote: >> >> >> Michael Bayer schrieb: >> > can you try r4030 please.... >> >> Thank you very much, r4030 fixes the described problems. :-) >> >> fs >> >> >> >> > > > > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "sqlalchemy" group. To post to this group, send email to sqlalchemy@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/sqlalchemy?hl=en -~----------~----~----~----~------~----~------~--~---