On Tue, Nov 12, 2019, at 12:20 AM, Paul Graves-DesLauriers wrote: > I’m reviewing the README.dialects and README.unittests files. It certainly > appears that this is a task that I can take on.
> > How do we go about splitting the Firebird support into a separate plugin? Or > perhaps, how was the sqlalchemy-access project created from the sqlalchemy > master? one step at a time, basically. create a repository, create the file structure, lift and move the firebird files from SQLAlchemy over to your new repository, start getting basic hello world style functionality going. Once you get something working we can transfer your repo into the sqlalchemy/ organization. > > Thanks, > Paul > > *From:* sqlalchemy@googlegroups.com <sqlalchemy@googlegroups.com> *On Behalf > Of *Mike Bayer > *Sent:* Monday, November 11, 2019 12:05 PM > *To:* noreply-spamdigest via sqlalchemy <sqlalchemy@googlegroups.com> > *Subject:* Re: [sqlalchemy] Continuing support for Firebird database > > > > On Fri, Nov 8, 2019, at 11:05 PM, Paul Graves-DesLauriers wrote: >> This is unexpected… >> >> I can do this if we can get things setup similarly to the sqlalchemy-access >> dialect. >> >> Is there a test set for confirming the dialect is acceptable for SQLAlchemy? >> Is there a sample test set I can use to confirm Firebird will work as >> expected (Like you use for SQL Server, Oracle, PostgreSQL, etc.)? If so, I’m >> willing to give it a shot. I am extremely happy with Firebird as a database >> and will probably end up doing this kind of work anyway… > > > SQLAlchemy contains a test suite that is explicitly for third party dialects > to aim towards. The vast majority of SQLAlchemy tests aren't needed for third > party dialects to support, so the third party suite contains a much more > carefully maintained set of "exportable" tests that every dialect should > address, either by ensuring support is present or by marking a certain > capability as skipped. > > The background for this system is discussed at > https://github.com/sqlalchemy/sqlalchemy/blob/master/README.dialects.rst. The > sqlalchemy-access work we just did allowed us to fix a few cases, so if > Firebird can target this that would be how it does its tests once on the > outside. > > > > >> >> Paul >> >> *From:* sqlalchemy@googlegroups.com <sqlalchemy@googlegroups.com> *On Behalf >> Of *Mike Bayer >> *Sent:* Friday, November 08, 2019 12:36 PM >> *To:* noreply-spamdigest via sqlalchemy <sqlalchemy@googlegroups.com> >> *Subject:* Re: [sqlalchemy] Continuing support for Firebird database >> >> Would you be interested in maintaining / owning / releasing Firebird >> separately, under github.com/sqlalchemy/sqlalchemy-firebird >> <http://github.com/sqlalchemy/firebird> ? Because this is not a widely used >> dialect and I can't maintain CI for it under my own umbrella, it would >> benefit by being maintained and released separately. We have recently >> modernized sqlalchemy-access with a new maintainer in a similar way. >> >> >> >> On Fri, Nov 8, 2019, at 1:57 PM, Paul Graves-DesLauriers wrote: >>> I saw in the SQLAlchemy 1.3 Documentation page for Firebird >>> <https://docs.sqlalchemy.org/en/13/dialects/firebird.html> that the >>> 'Firebird dialect within SQLAlchemy is not currently supported. The dialect >>> is not tested within continuous integration and is likely to have many >>> issues and caveats not currently handled.' >>> >>> I'd like to see the Firebird database have ongoing support within >>> SQLAlchemy. Firebird has been my database of choice since version 1.0, am >>> currently using it, and plan to continue using it in the future. It is >>> still in active development. >>> >>> For Python, I use the fdb DBAPI (official driver) along with Firebird >>> dialect3 (current). I would suggest removing support for the old dialect1 >>> and kinterbasdb driver to simplify maintenance and testing. >>> >>> >>> Can I help with getting the dialect tested within the continuous >>> integration and with resolving issues and caveats? I use Jenkins on a daily >>> basis and have been using Python for about 8 years. I'm now a performance >>> test engineer, but have many years of experience as a software developer as >>> well. I am also willing to help with documentation and support. >>> >>> Are there any other issues causing the Firebird database to losing ongoing >>> support for it? >>> >>> Thanks, >>> Paul >>> >>> >>> -- >>> SQLAlchemy - >>> The Python SQL Toolkit and Object Relational Mapper >>> >>> http://www.sqlalchemy.org/ >>> >>> To post example code, please provide an MCVE: Minimal, Complete, and >>> Verifiable Example. See http://stackoverflow.com/help/mcve for a full >>> description. >>> --- >>> You received this message because you are subscribed to the Google Groups >>> "sqlalchemy" group. >>> To unsubscribe from this group and stop receiving emails from it, send an >>> email to sqlalchemy+unsubscr...@googlegroups.com. >>> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/sqlalchemy/fe77d2d8-a1a0-4082-bf10-6e78e0ed75c0%40googlegroups.com >>> >>> <https://groups.google.com/d/msgid/sqlalchemy/fe77d2d8-a1a0-4082-bf10-6e78e0ed75c0%40googlegroups.com?utm_medium=email&utm_source=footer>. >> >> -- >> SQLAlchemy - >> The Python SQL Toolkit and Object Relational Mapper >> >> http://www.sqlalchemy.org/ >> >> To post example code, please provide an MCVE: Minimal, Complete, and >> Verifiable Example. See http://stackoverflow.com/help/mcve for a full >> description. >> --- >> You received this message because you are subscribed to a topic in the >> Google Groups "sqlalchemy" group. >> To unsubscribe from this topic, visit >> https://groups.google.com/d/topic/sqlalchemy/yvsgiNtVYSk/unsubscribe. >> To unsubscribe from this group and all its topics, send an email to >> sqlalchemy+unsubscr...@googlegroups.com. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/sqlalchemy/2932583d-e98e-4dea-9f0a-efb200c4648e%40www.fastmail.com >> >> <https://groups.google.com/d/msgid/sqlalchemy/2932583d-e98e-4dea-9f0a-efb200c4648e%40www.fastmail.com?utm_medium=email&utm_source=footer>. >> >> -- >> SQLAlchemy - >> The Python SQL Toolkit and Object Relational Mapper >> >> http://www.sqlalchemy.org/ >> >> To post example code, please provide an MCVE: Minimal, Complete, and >> Verifiable Example. See http://stackoverflow.com/help/mcve for a full >> description. >> --- >> You received this message because you are subscribed to the Google Groups >> "sqlalchemy" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to sqlalchemy+unsubscr...@googlegroups.com. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/sqlalchemy/012c01d596b2%24dda46020%2498ed2060%24%40dexmicro.com >> >> <https://groups.google.com/d/msgid/sqlalchemy/012c01d596b2%24dda46020%2498ed2060%24%40dexmicro.com?utm_medium=email&utm_source=footer>. > > -- > SQLAlchemy - > The Python SQL Toolkit and Object Relational Mapper > > http://www.sqlalchemy.org/ > > To post example code, please provide an MCVE: Minimal, Complete, and > Verifiable Example. See http://stackoverflow.com/help/mcve for a full > description. > --- > You received this message because you are subscribed to a topic in the Google > Groups "sqlalchemy" group. > To unsubscribe from this topic, visit > https://groups.google.com/d/topic/sqlalchemy/yvsgiNtVYSk/unsubscribe. > To unsubscribe from this group and all its topics, send an email to > sqlalchemy+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/sqlalchemy/7d25b9ba-0c52-4fe8-a8df-3f1057aab265%40www.fastmail.com > > <https://groups.google.com/d/msgid/sqlalchemy/7d25b9ba-0c52-4fe8-a8df-3f1057aab265%40www.fastmail.com?utm_medium=email&utm_source=footer>. > > -- > SQLAlchemy - > The Python SQL Toolkit and Object Relational Mapper > > http://www.sqlalchemy.org/ > > To post example code, please provide an MCVE: Minimal, Complete, and > Verifiable Example. See http://stackoverflow.com/help/mcve for a full > description. > --- > You received this message because you are subscribed to the Google Groups > "sqlalchemy" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to sqlalchemy+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/sqlalchemy/006301d59918%24f57889c0%24e0699d40%24%40dexmicro.com > > <https://groups.google.com/d/msgid/sqlalchemy/006301d59918%24f57889c0%24e0699d40%24%40dexmicro.com?utm_medium=email&utm_source=footer>. -- SQLAlchemy - The Python SQL Toolkit and Object Relational Mapper http://www.sqlalchemy.org/ To post example code, please provide an MCVE: Minimal, Complete, and Verifiable Example. See http://stackoverflow.com/help/mcve for a full description. --- You received this message because you are subscribed to the Google Groups "sqlalchemy" group. To unsubscribe from this group and stop receiving emails from it, send an email to sqlalchemy+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/sqlalchemy/58622c53-17e3-42ef-8842-24a6fe4fb0c5%40www.fastmail.com.
