Hi, sorry it took so long, got sick.
On Jan 7, 2008, at 5:05 PM, Jess Robinson wrote:
On Mon, 7 Jan 2008, Pedro Melo wrote:Sounds lovely, sorry I failed to read the second one, I should have looked there ;)Sure. I'll change: * server_version => mysql-server-version; * documentation in sqlt;* default (no mysql-server-version present) will generate the old ENUM code;
Attached a new patch version. Tests pass on my laptop but I still think there is room for improvement (more about this below).
The new patch keeps the producer arg as mysql_server_version, and adds a sqlt argument --mysql-server-version.
Tests and documentation updated. I could not find tests for sqlt arguments, I assume they don't exists yet.
Also, by default (no --mysql-server-version present), it will generate the backwards compatible ENUM ('0', '1') SQL.
As for further improvements, I think that --server-version or (my prefered version now) --target-version would be an excelent default producer argument. It would allow it to be used with all the SQL engines, to tweak their producers based on the target server version. For non-server producers, you could also target specific versions of it.
For example, if a new and improved version of Grapviz appears, with extra features, the Grapviz producer could use the --target-version to enable those new features.
If you agree, I would remove the --mysql-server-version, code the -- target-version, and make Producer::MySQL use that instead.
Best regards,
mysql-producer-boolean.diff
Description: Binary data
-- Pedro Melo Blog: http://www.simplicidade.org/notes/ XMPP ID: [EMAIL PROTECTED] Use XMPP!
------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
-- sqlfairy-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/sqlfairy-developers
