On Thu, 10 Jan 2008, Pedro Melo wrote:
> Hi,
>
> sorry it took so long, got sick.
No worries, no hurry.
> Attached a new patch version. Tests pass on my laptop but I still think
> there is room for improvement (more about this below).
>
> The new patch keeps the producer arg as mysql_server_version, and adds a
> sqlt argument --mysql-server-version.
>
> Tests and documentation updated. I could not find tests for sqlt arguments,
> I assume they don't exists yet.
>
> Also, by default (no --mysql-server-version present), it will generate the
> backwards compatible ENUM ('0', '1') SQL.
>
> As for further improvements, I think that --server-version or (my prefered
> version now) --target-version would be an excelent default producer
> argument. It would allow it to be used with all the SQL engines, to tweak
> their producers based on the target server version. For non-server
> producers, you could also target specific versions of it.
>
> For example, if a new and improved version of Grapviz appears, with extra
> features, the Grapviz producer could use the --target-version to enable
> those new features.
>
> If you agree, I would remove the --mysql-server-version, code the
> --target-version, and make Producer::MySQL use that instead.
Much coolness, nice!
I did ponder that in general something for indicating versions would be
useful, since we seem to cover a fair range now. If you feel like adding,
then it would be nice to keep it consistent, and update the parser to use
that arg too. (dont forget to allow both old+new in bin/sqlt for
compatibility)
Jess
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
--
sqlfairy-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/sqlfairy-developers
