> On 2011-09-16 23:17:01, Arvind Prabhakar wrote: > > src/java/com/cloudera/sqoop/io/NamedFifo.java, line 74 > > <https://reviews.apache.org/r/1938/diff/2/?file=41551#file41551line74> > > > > Thanks for making this change. Considering that there is at least one > > more system where this problem shows up, I suggest that we add an > > evnironment variable check, something like sqoop.use.mkfifo, which if set > > turns this behavior. > > Joey Echeverria wrote: > I don't like making things require a configuration if we don't need to. > How about I just check to see what's in the path? If mknod is there, if not > pick mkfifo. If neither is available, throw an error? Less work for the user, > works everywhere. I can do the check once when the class is loaded and then > just remember my choice. > > Joseph Boyd wrote: > mknod exists on mac os x, it just can't create a FIFO. > > I suggested in the JIRA that we try running mknod and then fall back to > running mkfifo if the mknod call returns a non-zero exit code.
I saw that after I posted. I could switch the logic and search for mkfifo first. I assume that mkfifo can always make a fifo, right ;) - Joey ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1938/#review1950 ----------------------------------------------------------- On 2011-09-16 22:14:55, Joey Echeverria wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1938/ > ----------------------------------------------------------- > > (Updated 2011-09-16 22:14:55) > > > Review request for Sqoop. > > > Summary > ------- > > Replaced the use of mknod with mkfifo in NamedFifo to improve compatibility > with Mac OS X. > > > This addresses bug SQOOP-339. > https://issues.apache.org/jira/browse/SQOOP-339 > > > Diffs > ----- > > src/java/com/cloudera/sqoop/io/NamedFifo.java 38656cb > > Diff: https://reviews.apache.org/r/1938/diff > > > Testing > ------- > > No new tests as the functionality is covered by an existing unit test. I ran > the existing unit test and it worked. I don't have a Mac to test on right > now, so it might be good to run the unit tests on one before commit. > > > Thanks, > > Joey > >
