> On 2011-09-16 21:00:37, Arvind Prabhakar wrote: > > Thanks for taking this up Joey. Considering the various platforms that > > Sqoop is used on, it is likely that this change may cause some backward > > compatibility issues for some. In order to avoid that, I would suggest > > conditionally using the mkfifo based on environment setting or command line > > option. > > > > Your thoughts? > > Joey Echeverria wrote: > Any comments on the latest version? > > Arvind Prabhakar wrote: > Sorry about the delay in responding Joey. I still have the same concern > that the default code-path has changed and it could cause regression on > systems where Sqoop otherwise has worked in the past. I would therefore > suggest that you default to the old way of doing things, and conditionally > (implicit or explicit), modify that behavior where necessary. > > Joey Echeverria wrote: > So, I've got two ideas for how to restructure it to default to mknod: > > 1) Try using mknod in the static initializer to create a fifo in /tmp. If > it fails, use mkfifo from now on. > 2) Always try using mknod in the create() method, and fall back to mkfifo > every time it fails. > > The one downside I see to 1 is it could falsely claim that mknod doesn't > work because of a, potentially temporary, environmental issue. Preferences?
I think #2 would work best, with some log message indicating that the default option has failed and trying a the mkfifo instead. Failure can be detected by stating the fifo file to see if it exists. While you are modifying that part of the code, it will also be good to log the command output which is currently being ignored. - Arvind ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1938/#review1944 ----------------------------------------------------------- On 2011-09-19 01:06:45, Joey Echeverria wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1938/ > ----------------------------------------------------------- > > (Updated 2011-09-19 01:06:45) > > > Review request for Sqoop. > > > Summary > ------- > > Replaced the use of mknod with mkfifo in NamedFifo to improve compatibility > with Mac OS X. > > > This addresses bug SQOOP-339. > https://issues.apache.org/jira/browse/SQOOP-339 > > > Diffs > ----- > > src/java/com/cloudera/sqoop/io/NamedFifo.java 38656cb > > Diff: https://reviews.apache.org/r/1938/diff > > > Testing > ------- > > No new tests as the functionality is covered by an existing unit test. I ran > the existing unit test and it worked. I don't have a Mac to test on right > now, so it might be good to run the unit tests on one before commit. > > > Thanks, > > Joey > >
