----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1938/#review2016 -----------------------------------------------------------
Code change looks good. On my linux system I tested it out by removing (1) mknod completely from the path, (2) keeping it but revoking the execute permissions, (3) replacing it with a dummy script that does nothing, and (4) replacing it with a dummy script that returned an non-zero exit code. In all but (3), the test failed since the Shell.execCommand() raised an exception (IOException in cases 1,2 and Shell$ExitCodeException in 4). This implies that if the mknod command fails, the routine will exit with error rather than retry it. One way to address it would be to put the Shell.exec in try/catch and log the first exception before retry. If it fails again with mkfifo, the exception can bubble up to the caller. - Arvind On 2011-09-21 17:13:30, Joey Echeverria wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1938/ > ----------------------------------------------------------- > > (Updated 2011-09-21 17:13:30) > > > Review request for Sqoop. > > > Summary > ------- > > Replaced the use of mknod with mkfifo in NamedFifo to improve compatibility > with Mac OS X. > > > This addresses bug SQOOP-339. > https://issues.apache.org/jira/browse/SQOOP-339 > > > Diffs > ----- > > src/java/com/cloudera/sqoop/io/NamedFifo.java 38656cb > > Diff: https://reviews.apache.org/r/1938/diff > > > Testing > ------- > > No new tests as the functionality is covered by an existing unit test. I ran > the existing unit test and it worked. I don't have a Mac to test on right > now, so it might be good to run the unit tests on one before commit. > > > Thanks, > > Joey > >
