> Hi Amos, > Amos Jeffries wrote: >> I just spent the afternoon going over Christos full patch for >> squid3-largeobj and only found a few very minor things. Though I still >> don't know squid well enough to tell if there is anything missed out. >> > Did you use it to download large files? Did you do some tests using it > (just browsing ot something else)? I believe that now it is in good > state...
I only read the patch file. <snips> >> Not sure whether these are needed, but its not clear either way without >> a >> compile test. >> peer_digest.cc chunk @787 >> - (int) > Needed here, else the compiler will produce a warning..... >> store_dir.cc chunk @330 >> - (uint64_t ) > Where is it? Ah, sorry. I must have copied the filename wrong. Patch file says its in src/store_digest.cc now line 247-254. Adding its the only change made, so would be nice to not do. Amos
