@xkaraman commented on this pull request.
> @@ -260,6 +263,14 @@ static int mod_init(void)
return -1;
}
}
+ if(_tps_methods_update_time_list.len > 0) {
+ if(parse_methods(
+ &_tps_methods_update_time_list,
&_tps_methods_update_time)
+ < 0) {
+ LM_ERR("failed to parse methods_update_time
parameter\n");
+ return -1;
+ }
+ }
You are right i think. What if we remove the len check. Does the parse_methods
allow empty string to set also the update_time?
Just to verify, if the user does not provide the modparam at all we want the
old behavior of updating the SUBSCRIBE right? That was the intention of
intitializing it to METHOD_SUBSCRIBE.
Otherwise, i can set to 0, and have a default_update_methods = SUBSCRIBE var
that is assigned only if the user does not provide the modparam.
If the user provided the modparam, and it's empty it should respect it and
update nothing, correct?
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4561#discussion_r2720448977
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4561/review/[email protected]>_______________________________________________
Kamailio - Development Mailing List -- [email protected]
To unsubscribe send an email to [email protected]
Important: keep the mailing list in the recipients, do not reply only to the
sender!
