@xkaraman commented on this pull request.
> @@ -1854,11 +1854,12 @@ int tps_db_update_dialog(
}
}
if((mode & TPS_DBU_TIME)
- && ((sd->b_tag.len > 0)
- && ((md->direction == TPS_DIR_UPSTREAM)
- &&
(msg->first_line.type == SIP_REQUEST))
- &&
(msg->first_line.u.request.method_value
- == METHOD_SUBSCRIBE))) {
+ && ((sd->b_tag.len > 0) && (msg->first_line.type ==
SIP_REQUEST)
+ && (((md->direction == TPS_DIR_UPSTREAM)
+ &&
(msg->first_line.u.request.method_value
+
== METHOD_SUBSCRIBE))
+ ||
((msg->first_line.u.request.method_value
+ ==
METHOD_INVITE))))) {
I agree on this, and it was one of my concerns as well. even if the user
provide more methods, only those two are curretnly supported.
SUBSCRIBE was upstream before and didn't want to change the behavior from my
side.
If all methods have common UPSTREAM and DOWNSTREAM update, it would simplify
the condition and allow bitmasking as well to be more extensible for other
methods as well.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4561#discussion_r2720459614
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4561/review/[email protected]>_______________________________________________
Kamailio - Development Mailing List -- [email protected]
To unsubscribe send an email to [email protected]
Important: keep the mailing list in the recipients, do not reply only to the
sender!
