@miconda commented on this pull request.
> @@ -1854,11 +1854,12 @@ int tps_db_update_dialog(
}
}
if((mode & TPS_DBU_TIME)
- && ((sd->b_tag.len > 0)
- && ((md->direction == TPS_DIR_UPSTREAM)
- &&
(msg->first_line.type == SIP_REQUEST))
- &&
(msg->first_line.u.request.method_value
- == METHOD_SUBSCRIBE))) {
+ && ((sd->b_tag.len > 0) && (msg->first_line.type ==
SIP_REQUEST)
+ && (((md->direction == TPS_DIR_UPSTREAM)
+ &&
(msg->first_line.u.request.method_value
+
== METHOD_SUBSCRIBE))
+ ||
((msg->first_line.u.request.method_value
+ ==
METHOD_INVITE))))) {
I would say that the direction does not matter and I would propose to remove
the condition on it and simplify the check to the bitmask matching.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4561#discussion_r2720755761
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4561/review/[email protected]>_______________________________________________
Kamailio - Development Mailing List -- [email protected]
To unsubscribe send an email to [email protected]
Important: keep the mailing list in the recipients, do not reply only to the
sender!
