On 05/20/2010 08:37 AM, Stephen Gallagher wrote:
On 05/20/2010 08:08 AM, Stephen Gallagher wrote:
On 05/20/2010 08:00 AM, David O'Brien wrote:
Stephen Gallagher wrote:
On 05/19/2010 10:29 PM, David O'Brien wrote:
nack.

1. After a long discussion with other writers a couple of days ago, we
came to the conclusion that using an article with "SSSD" was
incorrect,
because SSSD is a proper noun and a name. Hence, "performance
impact on
the SSSD" should read "performance impact on SSSD". I know this gets
cloudy if you expand "sssd" in your head, and that's why the
discussion
was as long as it was.

2. I'd recommend s/Also/Further at the beginning of a sentence like
this.

3. s/assure/ensure

4. s/see the manpages/refer to the man pages



Thanks for the review! Updated patch attached.


I realise I'm nit-picking now, but our Word Usage guide lists "man page"
as two words (see point 4, above).


Last version, acked off-list.


Accidentally resent the previous patch. Correct one attached.


*sigh* Still the wrong patch. One more try?

--
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
From 0ce738afd43dd75117a80e3b3f5fd516f63bd643 Mon Sep 17 00:00:00 2001
From: Stephen Gallagher <sgall...@redhat.com>
Date: Wed, 19 May 2010 09:33:47 -0400
Subject: [PATCH] Add enumerate details to the manpage and examples

---
 src/examples/sssd.conf  |    4 ++--
 src/man/sssd.conf.5.xml |   20 +++++++++++++++++++-
 2 files changed, 21 insertions(+), 3 deletions(-)

diff --git a/src/examples/sssd.conf b/src/examples/sssd.conf
index 3b67daeaf04aaac6ffd3b080928b68723bea28d2..e93cf51bc270e9accf696e5f06a1de57682daff3 100644
--- a/src/examples/sssd.conf
+++ b/src/examples/sssd.conf
@@ -55,10 +55,10 @@ reconnection_retries = 3
 ; auth_provider = ldap
 ; ldap_schema = rfc2307
 ; ldap_uri = ldap://ldap.mydomain.org
-; ldap_user_search_base = dc=mydomain,dc=org
+; ldap_search_base = dc=mydomain,dc=org
 ; ldap_tls_reqcert = demand
 ; cache_credentials = true
-; enumerate = true
+; enumerate = False
 
 # Example LDAP domain where the LDAP server is an Active Directory server.
 
diff --git a/src/man/sssd.conf.5.xml b/src/man/sssd.conf.5.xml
index c7071ab6cc48a8c4777e858f65763b46c7106cb7..0e7c5723e768123b220f2d50bdb6cdfbbbaeea46 100644
--- a/src/man/sssd.conf.5.xml
+++ b/src/man/sssd.conf.5.xml
@@ -435,6 +435,24 @@
                         <para>
                             Default: FALSE
                         </para>
+                        <para>
+                            Note: Enabling enumeration has a moderate
+                            performance impact on SSSD while enumeration
+                            is running. It may take up to several minutes
+                            after SSSD startup to fully complete enumerations.
+                            During this time, individual requests for
+                            information will go directly to LDAP, though it
+                            may be slow, due to the heavy enumeration
+                            processing.
+                        </para>
+                        <para>
+                            Further, enabling enumeration may increase the time
+                            necessary to detect network disconnection, as
+                            longer timeouts are required to ensure that
+                            enumeration lookups are completed successfully.
+                            For more information, refer to the man pages for
+                            the specific id_provider in use.
+                        </para>
                     </listitem>
                 </varlistentry>
 
@@ -848,7 +866,7 @@ cache_credentials = true
 
 min_id = 10000
 max_id = 20000
-enumerate = true
+enumerate = False
 </programlisting>
         </para>
     </refsect1>
-- 
1.7.0.1

_______________________________________________
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/sssd-devel

Reply via email to