On 05/20/2010 08:38 AM, Stephen Gallagher wrote: > On 05/20/2010 08:37 AM, Stephen Gallagher wrote: >> On 05/20/2010 08:08 AM, Stephen Gallagher wrote: >>> On 05/20/2010 08:00 AM, David O'Brien wrote: >>>> Stephen Gallagher wrote: >>>>> On 05/19/2010 10:29 PM, David O'Brien wrote: >>>>>> nack. >>>>>> >>>>>> 1. After a long discussion with other writers a couple of days >>>>>> ago, we >>>>>> came to the conclusion that using an article with "SSSD" was >>>>>> incorrect, >>>>>> because SSSD is a proper noun and a name. Hence, "performance >>>>>> impact on >>>>>> the SSSD" should read "performance impact on SSSD". I know this gets >>>>>> cloudy if you expand "sssd" in your head, and that's why the >>>>>> discussion >>>>>> was as long as it was. >>>>>> >>>>>> 2. I'd recommend s/Also/Further at the beginning of a sentence like >>>>>> this. >>>>>> >>>>>> 3. s/assure/ensure >>>>>> >>>>>> 4. s/see the manpages/refer to the man pages >>>>>> >>>>>> >>>>> >>>>> Thanks for the review! Updated patch attached. >>>>> >>>>> >>>> I realise I'm nit-picking now, but our Word Usage guide lists "man >>>> page" >>>> as two words (see point 4, above). >>>> >>> >>> Last version, acked off-list. >>> >> >> Accidentally resent the previous patch. Correct one attached. >> > > *sigh* Still the wrong patch. One more try? > >
Pushed to master and sssd-1-2. -- Stephen Gallagher RHCE 804006346421761 Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.redhat.com/promo/vendor/ _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel