I have made some more modifications to the LabelTag to make it more extensible.
The way the tag works now is: doStartTag() -> starts the span (if styles are applied) doAfterBody() -> Determines which label to use (from the resource bundle or from the body content.) doEndTag() -> ends the span (if styles are applied) Styles are still applied based on whether there is an error associated with the property. If anyone wants to use an '*' or any other symbol to the right or left of the label, just override the start or end tag. Erik: If you want, you can use just one attribute by overriding the setKey method and passing the key to the super's setProperty method; Thanks for helping refine this, Jonathan -----Original Message----- From: Erik Hatcher [mailto:[EMAIL PROTECTED] Sent: Wednesday, June 25, 2003 2:56 PM To: Struts Developers List Subject: Re: A Custom tag using <bean:message /> and validation ... On Wednesday, June 25, 2003, at 02:01 PM, David Graham wrote: > Struts doesn't have the luxury of living in one development shop. I > understand your need for customizations for your particular conventions > but we can't force them on others. So, we'll be ok as long as the > Struts > version provides some basic useful functionality and allows easy > subclassing. Agreed! And +1 The main point I wanted to make here, just to clarify, is for us to always consider avoiding duplication and to clearly denote where we are doing so and why.... which you have done nicely. LabelTag is something Struts needs in some form or another... keep up the good work folks! Erik --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
