On Wed, Sep 27, 2017 at 01:50:32PM +0200, Tomaz Canabrava wrote: > On Wed, Sep 27, 2017 at 5:41 AM, Dirk Hohndel <d...@hohndel.org> wrote: > > > On Tue, Sep 26, 2017 at 11:21:59PM -0400, Federico Masias wrote: > > > > > > > > > > > > Yes it is. Please do. > > > > > > > > > > Done. > > > > Thanks, already merged > > > > > > > Facebook upload mostly works, but Subsurface asks for an album name > > to > > > > place the photo into an album... but Facebook simply posts it to an > > album > > > > called "Subsurface Photos" -- no mention of the user defined album > > > > anywhere. I'd also caution against using the verbiage of "profile > > picture" > > > > in the instructions when referring to the dive profile graph, as that > > > > phrase means something else completely to Facebook users. > > > > > > > > Both great points. Can you fix this in the code? Otherwise, please > > raise > > > > an issue on Github. > > > > These are both easy to address > > > > > > > > > > > I was able to change the string, but I've noticed a few more things about > > > the parameters that are passed to Facebook, so I'll raise a Github issue > > > about that shortly, but the short version is that I'm not sure if we're > > > passing the wrong info to the FB API, or it's being ignored -- both for > > the > > > album name and privacy settings. I don't have time tonight to > > investigate, > > > and I'm sure someone around here is much better at it than I -- but if > > it's > > > not fixed by someone else, I'll try and follow up on it when I do have a > > > bit more time. > > > > Tomaz recently updated our code to the latest API version. Did you test > > with the latest test version or with the last release version? If the > > former, let's make sure you tag @tcanabrava in the issue so he can look > > into this to see if maybe something got mixed up with the change to the > > newer API. > > > > The latest api version was just a number change, no actuall api methods > where modified.
Did you have a chance to take a look at the bug report? https://github.com/Subsurface-divelog/subsurface/issues/612 Thanks /D _______________________________________________ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface