Daniel wrote:
Jens Hatlak wrote:
But beware, even that can be turned
down if the SM reviewers don't want it.
Hey, Jens, I know the team that produces SeaMonkey is undermanned, but
does that mean that someone that has nothing to do with the SeaMonkey
Council rules on modifications, etc??
Well, this is a bit shady from what I know. There are multiple tiers
when it comes to decision-taking. From what I understand (KaiRo will
surely correct me if I'm wrong; excluding code shared with FF or TB in
the following):
Tier 1: The SeaMonkey Council
<http://www.seamonkey-project.org/about>
I have yet to see (read) them making actual decisions as a group. Maybe
I just didn't watch it closely enough. In any case I think it happens
very rarely. And I think that's a good thing.
Tier 2: Module Owners
<http://www.seamonkey-project.org/dev/project-areas>
The Owner column lists the owner of the respective module. His decision
can be authoritative, but usually it's simply that the reviewer and
superreviewer must give a positive review (approve a change).
Tier 3: Superreviewers
<http://www.seamonkey-project.org/dev/review-and-flags>
Currently, a superreview is required for all UI changes, changes
spanning multiple modules, all MailNews changes, and very complex
changes. This might change in the future, maybe using the ui-review flag
for UI changes (which does not necessarily mean the actual people to be
asked change).
Tier 3: Reviewers (Peers)
If neither the superreviewer nor the module owner disagrees (as I said
the Council is usually not involved), the reviewer takes the decision
whether a code change is admitted.
Tier 3: Developers (non-reviewers)
Changes can be put up for review by anyone who has the knowledge (and a
Bugzilla account, which is free for all) to come up with a patch.
Obviously, if no patch comes up, the problem is not getting fixed. But
since the developer decides what s/he proposes, s/he has all the power
unless the patch is not accepted by higher tiers.
Now you might ask why I said shady. Here is why:
- Both the SeaMonkey Council members and superreviewers list is
outdated, and for reasons unknown to me they are not getting updated. In
reality, Neil is our only superreviewer and Standard8, biesi and
ajschult have hardly contributed anything to SeaMonkey for years
(Standard8 because he's now working on TB exclusively).
- No-one has written down the tier model as described above before and
confirmed that it applies.
- KaiRo seems to have a special position that is not written down
anywhere (and I hope that will change when we meet!). I sometimes have
the feeling he is thought to be Tier 0.
HTH
Jens
--
Jens Hatlak <http://jens.hatlak.de/>
SeaMonkey Trunk Tracker <http://smtt.blogspot.com/>
_______________________________________________
support-seamonkey mailing list
[email protected]
https://lists.mozilla.org/listinfo/support-seamonkey
