Hi all, While packaging suspend I ran in a few design problems, which I solved (IMHO) in an elegant way.
First the fact that if you want to both suspend-to-disk and suspend-to-both in a regular basis you need to config files which are identical except for a line 'suspend to both ='. This is not nice because the user has two keep these files in sync, which can cause dataloss if per accident the suspend.conf file on the initramfs has a different swap-partition then one of the config files (OK, changes are slim, but still). Second, suspend is not a good name for a binary. Because (as other people have brought up already) suspend is a build in command in bash. Also it is a bit generic, the rest of the world seems to agree that suspend (without any additional info) == s2ram. So I propose to switch behavior of the binary on the name it is called by. So if you call /usr/sbin/s2both It will suspend to ram after saving state to disk if called as. /usr/sbin/s2disk (and any other name, as a matter of fact) It will simply power off. So know we have s2disk, s2ram and s2both. Isn't that nice and consistent;)? I attached a patch that does just that. To avoid confusion it also removes the s2ram configuration option. Oh, the patch also includes some additional changes to the Makefile to make installation by distributions easier (by setting DESTDIR). grts Tim
s2both.patch
Description: Binary data
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________ Suspend-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/suspend-devel
