On Sat, Jul 21, 2007 at 09:01:03AM +0300, Alon Bar-Lev wrote: > On 7/21/07, Tim Dijkstra <[EMAIL PROTECTED]> wrote: > > On Fri, 20 Jul 2007 22:20:51 +0200 > > "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote: > > > > > > Yet another patch in the suspend2 feature-set series. > > > > It sets cpufreq to maximum during the cycle. > > > > I haven't looked at the patch, but this doesn't really sound essential > > for uswsusp. Maybe it should go into pm-utils or similar. > > Not it can't.
Of course it can :-) > These utilities use periodic status scan. > While you need to modify the state at specific time (before all > processes are frozen). > > However, you can delegate this to the hibernate-script... Just like > the pci-state, vbetool and radeontool, but then why these are included > in suspend? s2ram has a plain simple goal: do everything to get the video back working. To do that, it needs pci-state (although i don't have a single positive reaction on that option), vbetool, radeontool and it might even get more hacks in the future. The reason is, that this is IMHO much better to have in one binary (you don't need, for example, a file to store the VBE state etc). s2disk also has a simple goal: suspend to disk and resume from disk. Everything else, like "module unloading", "preparing the boot entry for resume", "unmount external harddrives" etc.pp. is not subject of s2disk but of higher level wrappers. Think of s2disk and s2ram as part of the kernel, basically. > Also there is the issue of resuming... I guess you don't have pm-utils > in your initramfs... :) Just put the performance governor in the initramfs. -- Stefan Seyfried QA / R&D Team Mobile Devices | "Any ideas, John?" SUSE LINUX Products GmbH, Nürnberg | "Well, surrounding them's out." This footer brought to you by insane German lawmakers: SUSE Linux Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ Suspend-devel mailing list Suspend-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/suspend-devel
