Hi Richard and Stuart,

I was looking at the BinaryContentIngester code to try to make my own ingester 
and I found the ORIGINAL bundle duplication bug:

> Interesting - that looks like a bug with the DSpace implementation (ORIGINAL 
> bundle duplication).  I have some time scheduled to work on this 
> implementation over the next month to six weeks, so will look for this and 
> try to put in a fix.  Also, I'll look into whether the content type can be 
> put into the bitstream format field.

In BinaryContentIngester, line 138:

        Bundle original = null;

is assigned but never used because at lines 148:

        Bitstream bs = item.createSingleBitstream(deposit.getInputStream());

which creates a new bundle disregarding the original bundle.
I this code should solve the problem, and also add the bitstream format field:

        Bitstream bs = original.createBitstream(deposit.getInputStream());
        BitstreamFormat format = this.getFormat(context,deposit.getFilename());
        bs.setFormat(format);

At least from my short testing, this works. Should I submit this as an official 
bug to DSpace?

Cheers
Marco



------------------------------------------------------------------------------
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here 
http://p.sf.net/sfu/sfd2d-msazure
_______________________________________________
sword-app-tech mailing list
sword-app-tech@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/sword-app-tech

Reply via email to