Matthias, Some random thoughts and questions about your recent changes to the Controller (http://trac.symfony-project.com/trac/changeset/4650):
- I'm not very comfortable with the usage of a sfParameterHolder object for the action stack. I think you can migrate all this code into a sfActionStack object (or whatever you want to call it). It will cleanup the Controller and separate the controller logic and the stack logic. - If I understand correctly, you moved the dispatch() method from the sfFrontWebController to the sfWebController. Why? The dispatch notion belongs to the front controller design pattern. - The new "scope" filters.yml parameter is yet to be used? - Why do you use a $throwExceptions argument in the makeAction() method? Why don't you throw exceptions and catch them when needed in the sfExcutionFilter. The interface will be much cleaner, a makeAction() method always returns an action instance. By the way, try to keep your commits atomics as it makes reviewing the code easier. Fabien --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "symfony developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/symfony-devs?hl=en -~----------~----~----~----~------~----~------~--~---
