Le 17/09/2012 17:51, Michael C a écrit :
I personally (from experience) have found that features blocking a
release can end in disaster and can upset the whole principal of a
time-based release model as the feature can end up delaying the
release; especially if it's a feature that many want but not many want
to help with.
As for > 5.3, at the moment 5.2 is the most used PHP version; followed
closely by 5.3. However the amount of users/hosts using 5.4 is
currently quite small and isn't worth thinking about until at least
2.7 or 3.0 (2015 or later). The fact that 5.3 was first released in
2009 and the fact that it still is not as used as 5.2 (2006) is shocking.
I think having to complete the whole checklist done for something
straight away for something that might not be used might put off new
contributors. As has been suggested a 2-step PR process where after it
is mostly done; if it looks like it will be merged then complete the
checklist (documentation etc.) rather than straight away. This also
means that if the developer is asked to change anything significant
this can be done before documentation etc. is written and it therefore
means that does not also need updating.
Merging the PR before the documentation PR is done is a bad idea IMO. It
will lead to the same issue than currently: no doc PR done in many cases.
However, as Fabien said in a previous mail, having the full checklist is
not required to open the PR. It would be required to merge it, meaning
you can start writing the doc once the code review has validated the way
it is done.
--
Christophe | Stof
--
If you want to report a vulnerability issue on symfony, please send it to
security at symfony-project.com
You received this message because you are subscribed to the Google
Groups "symfony developers" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/symfony-devs?hl=en
