On 9/17/12 10:57 AM, Christophe COEVOET wrote:
Merging the PR before the documentation PR is done is a bad idea IMO. It
will lead to the same issue than currently: no doc PR done in many cases.
However, as Fabien said in a previous mail, having the full checklist is
not required to open the PR. It would be required to merge it, meaning
you can start writing the doc once the code review has validated the way
it is done.
--
Christophe | Stof
This is actually one of the reasons why Drupal's inline Docblocks are so
much more extensive than Symfony's. We rely on the docblocks for much
of our developer-facing documentation. That means there's no separate
patch/PR for documentation about a system, at least at the code level.
If the documentation isn't "ready", it's obvious from the PR itself.
Architectural-level documentation is a separate matter and that can't
really be merged into the code base sanely, but having more of the
documentation in the code itself makes it easier to enforce adding code
changes and matching documentation at the same time.
--Larry Garfield
--
If you want to report a vulnerability issue on symfony, please send it to
security at symfony-project.com
You received this message because you are subscribed to the Google
Groups "symfony developers" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/symfony-devs?hl=en
