Comment #71 on issue 1598 by ronan.l...@gmail.com: New polynomials
manipulation module
http://code.google.com/p/sympy/issues/detail?id=1598
Well, here are some comments.
General comments:
* Many identifiers are too short. For instance, DUP should be
DenseUnivariatePolynomial, or something like that. DMF.rep is excessively
cryptic.
* The first argument of a method should be named 'self'.
Concerning 'Algebra' and its subclasses:
* The name seems to be a misnomer. Instances of 'Algebra' aren't algebras
but
rings, I believe (OK, rings can always be considered as algebras over
themselves but
it's contrived).
* Why are there get_* methods? Shouldn't these be properties?
* Algebra.__getitem__: I can see the appeal in having ZZ[X] just work,
but this is
a gross violation of Python's semantics. Also, it's inconsistent with the
way
__call__ is defined.
* Are Ring.quo and Ring.exquo reversed?
Concerning the first commits:
* "Import any() and all() in runtests.py": Why?
* as_Add and as_Mul duplicate existing functionality (i.e. make_list(...,
Add),
make_list(..., Mul)). as_Pow seems to be a copy of as_base_exp.
* 4th commit (new methods in Integer): The first argument of a method
should be
named 'self'. Besides, a.gcd(b) is a really weird syntax.
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
"sympy-issues" group.
To post to this group, send email to sympy-iss...@googlegroups.com.
To unsubscribe from this group, send email to
sympy-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/sympy-issues?hl=en.
