Comment #23 on issue 1587 by asmeurer: Polynomials docs
http://code.google.com/p/sympy/issues/detail?id=1587
There's no reason to have it in the 0.7.0 release since it wasn't in
0.6.7.
I agree. Let's just change the default now and remove it, and add tests
with links to this issue to make sure the old behavior doesn't come up
again.
Concerning polys12, I don't think it's a good idea to push it in without
an actual review.
So review it :)
Actually, since my integration work is based highly on the polys, I have
taken a high interest to any change that Mateusz has pushed to his polysn
branches. Basically, whenever I have seen that he has pushed something, I
go in and look at it, and occasionally I note some things that need to be
fixed as comments to his GitHub repository (see
https://github.com/mattpap/sympy-polys/comments). So you can consider that
to be a review. The changes since polys11 can definitely be considered to
be reviewed since I have integration3 based on that branch and have been
using the changes for some time. Maybe we should require that any polys
related fix from my integration3 branch gets pushed in with polys12, since
usually when I found a bug in the polys I just fixed it myself.
Speaking of GitHub comments, here are the comments from GitHub that don't
seem to have been fixed/addressed yet:
- Chris's comment at
https://github.com/mattpap/sympy-polys/commit/a6b5ee50490db9f067dac27f35f7e2843505e71f#sympy/logic/boolalg.py-P6
- There needs to be a ? option to the interactive_traversal() function:
https://github.com/mattpap/sympy-polys/commit/f261914d57be0b1e317fa8b226954098910717a3#comments
- The message printed when gmpy is not available should use the warnings
module:
https://github.com/mattpap/sympy-polys/commit/5d7d612e1e193b3e75a7c8344e287f305f0b323b#sympy/polys/domains/__init__.py-P25.
Again, these are all fixes that I can do if you do not have time, Mateusz.
--
You received this message because you are subscribed to the Google Groups
"sympy-issues" group.
To post to this group, send email to sympy-iss...@googlegroups.com.
To unsubscribe from this group, send email to
sympy-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/sympy-issues?hl=en.
