Many thanks for the patch, Fabian, I really appreciate the new syntax, which is much more user-friendly.
2009/8/5 Ondrej Certik <ond...@certik.cz>: > > Looks good in general, but before we push this in, please improve the > doctest coverage to 100%: > > $ bin/coverage_doctest.py sympy/assumptions/assume.py > ---------------------------------------------------------------------- > sympy/assumptions/assume.py > > Missing documentation: > * expr(self) > * key(self) > * value(self) > > > Missing doctests: > * list_global_assumptions() > * remove_global_assumptions(*assump) > * clean_global_assumptions() > * eliminate_assume(expr, symbol=None) > > > Indirect doctest (function name doesn't occur in doctests): > * register_global_assumptions(*assump) > > Use "# indirect doctest" in the docstring to surpress this warning > SCORE sympy/assumptions/assume.py: 12% (1 of 8) > ---------------------------------------------------------------------- > > > > The same about the handlers/, do you think there should be no example > doctests? I think there should, at least in the classes, but I think > it should be in all methods. I have no idea how to use it without the > doctests. I'd like to remove all the global assumptions functions and replace it with an ordinary Python set of assumptions, for simplicity's sake. (It already has add(), remove(), clear(), copy() and other stuff which could be nice when working with different "contexts" of assumptions.) If you agree, I'll go for it. :) Vinzent --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "sympy-patches" group. To post to this group, send email to sympy-patches@googlegroups.com To unsubscribe from this group, send email to sympy-patches+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sympy-patches?hl=en -~----------~----~----~----~------~----~------~--~---
