On Jul 2, 2009, at 11:12 PM, Andy Ray Terrel wrote:
> > Wow this looks really nice, I'm glad to see others extending these > code generation features. > > Some comments regarding the request for review, using the commit > 194edc73e6743c666315821a0c2ead0eb93588a3 . Overall I am +1 for > pushing but I would like to see a few small changes, probably move > some of the comments into issues into themselves. > > fcode.py > ----------- > > * I don't like the repeating of many of functions that ccode has as > well. It seems that we could have a low level code generator that is > general enough to abstract many things, such as printing the implicit > functions and constant values. For example print pow, some special > functions and constants. This is probably a whole new issue though not > something to stop the code from being pushed. Maple's code generator converts to an intermediate format and then is converted to the final form. That may be an idea if multiple languages are going to be supported. That way, some common procedures can be done and then the language specific forms/optimizations can be done after. Like Andy says, it's not a reason to stop the code, but it's a possibility since things like MATLAB/Octave or Scilab could be other possible outputs. Cheers, Tim. --- Tim Lahey PhD Candidate, Systems Design Engineering University of Waterloo http://www.linkedin.com/in/timlahey --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "sympy" group. To post to this group, send email to sympy@googlegroups.com To unsubscribe from this group, send email to sympy+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sympy?hl=en -~----------~----~----~----~------~----~------~--~---
