Some comments:
* Why did you make PrimeField an old-style class? Unless you have a very
good reason, it should be new-style (i.e. declare it with "class
PrimeField(object):...")
* I don't like that str(PrimeField(5)) is {0, 1, 2, 3, 4}. For me, this
is the set of the 5 smallest natural integers, which is not at all the
same thing as F_5.
* I don't see what's abstract about prime fields: they're concrete
objects and easily constructed. So, I think the module should be not be
named "abstractalgebra" but "algebra" (or something else that doesn't
contain "abstract").
Cheers,
Ronan
--
You received this message because you are subscribed to the Google Groups
"sympy" group.
To post to this group, send email to sy...@googlegroups.com.
To unsubscribe from this group, send email to
sympy+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/sympy?hl=en.
