On 17 juin, 03:05, smichr <smi...@gmail.com> wrote: > On Jun 15, 11:37 pm, Ondrej Certik <ond...@certik.cz> wrote: > > > On Tue, Jun 15, 2010 at 10:11 AM, smichr <smi...@gmail.com> wrote: > > > There were a large number of changes pushed in today. Were these all > > > issues that were up for public review? (If there were issue numbers > > > attached to the changes in the commit log I wouldn't have to ask but I > > > only saw one of the nearly 30 that had a reference to an issue number.) > > > I can see about 5 new patches from Aaron fixing mpmath. Are those the > > patches you are talking about? Or some different ones. > > No, all the patches which were pushed on the 15th. As Vinzent said, > these apparently have been on the todo list for some time and perhaps > that's why they had moved off my radar as being something to watch out > for as I did my work. It would still be nice if (at least in the > comment of the commit, the commit log) if people would put an issue > number. > > Regarding the commits in 1766, Vinzent, there is no need to review > 1766 as a whole. Since May 11 (as per the suggestion in discussion > "review request") they have been split into separate branches. As a > result of not being able to easily rebase on the latest master, I am > now submitting new single-commits-over-master branches--branches, not > commits in 1766--for review. Most of the ones submitted so far are far > from monolithic and should be a quick review :-).
Yeah, this morning I had the time to review and push in a few. :) > Thanks for the upkeep, Vinzent. You aren't the only one reviewing with > a license to push, though, so it doesn't all fall on your shoulders. Well, pushing in is not the problem, this is done quickly. But apparently most do not have the time to review patches for sympy. :) Vinzent -- You received this message because you are subscribed to the Google Groups "sympy" group. To post to this group, send email to sy...@googlegroups.com. To unsubscribe from this group, send email to sympy+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sympy?hl=en.
