On Mon, Nov 21, 2011 at 5:58 PM, Matt Habel <habel...@gmail.com> wrote:
> The first one is more along the lines of what I'm asking. Lots of the
> test files do things intentionally to make the tests correct logically
> that don't line up with checking in lint or flakes. For example,
> raises needs a string that has functions in it. This doesn't register
> as the function being used so the import is worthless in flakes mind.
> There are lots of examples, x being redefined with odds only, or
> something like that. So to check these files I would need to
> understand all the tests... which would be hard for something like the
> integrals or other higher level maths.
Right. This falls into the category of what I was saying, where it
doesn't know everything about the code. So for those things, you can
just ignore them. But you should double check to make sure that it
really should be done that way, and that there isn't really some bug
in the test file.
And by the way, if you can't understand what's going on because you
don't understand the math (or for whatever reason), feel free to ask
here about it.
Aaron Meurer
>
> On Nov 21, 7:40 pm, Aaron Meurer <asmeu...@gmail.com> wrote:
>> I'm not sure what you mean. If you mean do you need to look at the
>> pyflakes errors for the test files, then the answer is yes, because
>> that is also code that is run (when the tests are run), so if there
>> are for example extra imports there, then they should be removed.
>>
>> If you're asking if you should run the tests when you're done, then
>> the answer is also yes, because you need to verify that you didn't
>> mess anything up.
>>
>> So, either way, the answer is "yes".
>>
>> Aaron Meurer
>>
>>
>>
>>
>>
>>
>>
>> On Mon, Nov 21, 2011 at 3:54 PM, Matt Habel <habel...@gmail.com> wrote:
>> > Do the test files need to be checked?
>>
>> > On Nov 21, 5:29 pm, "krastanov.ste...@gmail.com"
>> > <krastanov.ste...@gmail.com> wrote:
>> >> pyflakes is fine. Good luck with your work.
>>
>> >> On 21 November 2011 23:07, Matt Habel <habel...@gmail.com> wrote:
>>
>> >> > So will pyflakes be satisfactory? Or should I go the full length and
>> >> > use pylint on all the things?
>>
>> >> > On Nov 21, 5:05 pm, Aaron Meurer <asmeu...@gmail.com> wrote:
>> >> > > Exactly. This is why I put that warning in there. I was thinking of
>> >> > > pylint. There's supposed to be a way to customize pylint, so that you
>> >> > > can disable the useless warnings. Otherwise, I would just stick to
>> >> > > pyflakes.
>>
>> >> > > And note that sometimes the tests will still pass, e.g., when a
>> >> > > variable is not defined because that particular code path is not
>> >> > > covered by the tests. You can see what lines are covered by using the
>> >> > > ./bin/coverage_report.py script (I think we also have some tasks for
>> >> > > this too).
>>
>> >> > > Aaron Meurer
>>
>> >> > > On Mon, Nov 21, 2011 at 3:01 PM, Matt Habel <habel...@gmail.com>
>> >> > > wrote:
>> >> > > > Pylint is giving me a buttload of errors that don't really seem like
>> >> > > > errors. The tests run and pass fine, so I really can't figure out
>> >> > > > what
>> >> > > > pylint is complaining about. Maybe I set it up wrong?
>>
>> >> > > > On Nov 21, 4:54 pm, Aaron Meurer <asmeu...@gmail.com> wrote:
>> >> > > >> The functions module is fine. I just tried it, and I think they
>> >> > > >> can
>> >> > > >> all be fixed. The only exception would be if pyflakes has made a
>> >> > > >> mistake and things that something is wrong but really isn't (this
>> >> > > >> can
>> >> > > >> happen sometimes due to the dynamic nature of Python).
>>
>> >> > > >> I think it's actually pylint, not pyflakes, that I was thinking of
>> >> > > >> regarding that comment. I will modify the task description to make
>> >> > > >> this clear. Note that pylint gives way more output, but a lot of
>> >> > > >> it
>> >> > > >> is things like "Invalid name "z" (should match
>> >> > > >> [a-z_][a-z0-9_]{2,30}$)", but short or long names like that are
>> >> > > >> actually fine. You can use pylint or pyflakes to do this task (but
>> >> > > >> if
>> >> > > >> you choose pylint, ignore the invalid name and "too many..."
>> >> > > >> warnings).
>>
>> >> > > >> Aaron Meurer
>>
>> >> > > >> On Mon, Nov 21, 2011 at 2:20 PM, Matt Habel <habel...@gmail.com>
>> >> > wrote:
>> >> > > >> > Hi there mentors and others of this project, I am just following
>> >> > > >> > up
>> >> > on
>> >> > > >> > my task claim from earlier today. As stated, I need to find a
>> >> > > >> > good
>> >> > > >> > module to work on, would the functions module be okay?
>>
>> >> > > >> > Also, what kind of errors are skippable?
>>
>> >> > > >> > Thanks
>>
>> >> > > >> > --
>> >> > > >> > You received this message because you are subscribed to the
>> >> > > >> > Google
>> >> > Groups "sympy" group.
>> >> > > >> > To post to this group, send email to sympy@googlegroups.com.
>> >> > > >> > To unsubscribe from this group, send email to
>> >> > sympy+unsubscr...@googlegroups.com.
>> >> > > >> > For more options, visit this group athttp://
>> >> > groups.google.com/group/sympy?hl=en.
>>
>> >> > > > --
>> >> > > > You received this message because you are subscribed to the Google
>> >> > Groups "sympy" group.
>> >> > > > To post to this group, send email to sympy@googlegroups.com.
>> >> > > > To unsubscribe from this group, send email to
>> >> > sympy+unsubscr...@googlegroups.com.
>> >> > > > For more options, visit this group athttp://
>> >> > groups.google.com/group/sympy?hl=en.
>>
>> >> > --
>> >> > You received this message because you are subscribed to the Google
>> >> > Groups
>> >> > "sympy" group.
>> >> > To post to this group, send email to sympy@googlegroups.com.
>> >> > To unsubscribe from this group, send email to
>> >> > sympy+unsubscr...@googlegroups.com.
>> >> > For more options, visit this group at
>> >> >http://groups.google.com/group/sympy?hl=en.
>>
>> > --
>> > You received this message because you are subscribed to the Google Groups
>> > "sympy" group.
>> > To post to this group, send email to sympy@googlegroups.com.
>> > To unsubscribe from this group, send email to
>> > sympy+unsubscr...@googlegroups.com.
>> > For more options, visit this group
>> > athttp://groups.google.com/group/sympy?hl=en.
>
> --
> You received this message because you are subscribed to the Google Groups
> "sympy" group.
> To post to this group, send email to sympy@googlegroups.com.
> To unsubscribe from this group, send email to
> sympy+unsubscr...@googlegroups.com.
> For more options, visit this group at
> http://groups.google.com/group/sympy?hl=en.
>
>
--
You received this message because you are subscribed to the Google Groups
"sympy" group.
To post to this group, send email to sympy@googlegroups.com.
To unsubscribe from this group, send email to
sympy+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/sympy?hl=en.
