A few of the review requests have been cleared, but there are still several remaining. In addition, issues 2061, 2988, 2990, 2991, 2996, 2997, 2998, 3000, 3003, 3005 and 3007 were (mostly) raised when I went through looking at the use of as_coeff_mul() throughout sympy. I made minor correction in 25 mostly independently reviewable commits, submitted as 1 pull request (since many build off of earlier commits). In reverse order the commits are:
87b9806 add tests for issues and remove scratch docstring in mul.py d3310a3 trigonometric; hide new_rawargs processing d33ca49 use _coeff_isneg in str._print_Mul 28905ee simplify coeff code and add See Also eaa1e31 simplify: collect (issues 2997, 2998) and as_coeff_mul changes ace172e pretty: use _coeff_isneg bbf3c24 precedence: use _coeff_isneg 17e5381 power: allow (x**4.0).subs(x**2.0, ,y) -> y**2.0 53ce13f power: as_numer_denom uses _coeff_isneg and skips d-process if d==1 282bb3a power subs b commutative -> positive; exp subs if b pos, e real 30956ca order: use free_symbols and filtering of as_coeff_mul 7f41344 numbers: use _coeff_isneg; discard leading number in foo of 0**foo d404ec0 Mul.flatten process imaginary symbols when oo is a factor bbbc527 mathml; use _coeff_isneg and reorganize print_Mul 8d744f2 eliminate intermediate var in latex.py 5f51e93 latex_ex looks for literal negative sign 69d3c70 hyperbolic: use _coeff_isneg to test sign of leading Number 9cc65e2 function as_coeff_mul mods and pep8 edits d37d439 exprtools.decompose_powers as_coeff_mul edits 27c13f7 expr: Floats are now removed properly from within a sqrt 9e347e7 as_coeff_mul extracts the -1 from -oo 7eb4702 simplify and annotate exp.eval code and open inline ifs e454ac6 don't use match in exp.eval method 509ded4 Abs removes factors of known sign d23a6d0 no prehandling is necessary in _get_indices_Mul e0d57f5 spelling corrections I would sure appreciate being able to clear out this work. If other work gets pushed in without this getting reviewed, it makes it hard to maintain. -- You received this message because you are subscribed to the Google Groups "sympy" group. To post to this group, send email to sympy@googlegroups.com. To unsubscribe from this group, send email to sympy+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sympy?hl=en.
