On Sat, Mar 31, 2012 at 4:12 AM, Bharath M R <catchmrbhar...@gmail.com> wrote: > > > On Friday, March 30, 2012 11:41:42 PM UTC+5:30, Aaron Meurer wrote: >> >> This looks very good so far. Here are some comments: >> >> - The link http://www.shaatra.org/2011/main/home takes me nowhere. >> >> - Include Tupper's thesis in the references section. >> >> - As Stefan noted, the syntax in your pseudo-code is not the best: >> You should use expressions instead of strings. The expression should >> go first (ideally, including the interval would be optional, and it >> would just compute it automatically). You have to somehow note which >> interval is for x and which is for y; there's no way for it to know >> which one you want to be on which axis. >> >> - min and max are called Min and Max in SymPy. >> >> - Assumedly the min/max example is wrong. They should have more than >> one argument. >> >> - You have an extra bracket in the first week 3 example. >> >> - I think abs, floor, and acos are all implemented in mpmath already. > > floor and inverse trigonometric functions are not implemented for mpi. > >> >> - I'm also confused about x**(1/3). I understood the paper to mean >> that it has difficulty with "exponential" functions like exp(x). > > exp(x) won't be a problem because it is monotonic, and hence evaluating > at the end points of the interval suffices. > The problem in the paper was that 1/2 is represented in floating points and > hence it is difficult to track whether the power can be evaluated for > negative x. > As we have the implementations of rational in sympy, implementing such > functions > won't be a problem. I have removed it from my application.
So should the example in your proposal be sqrt(x) instead of x**0.5? Aaron Meurer > >> - In the "Continuity Tracking" section, you need to add newlines before >> the *'s. >> >> - Could you talk a little more about how much will be involved in >> writing the interval library for numpy? >> >> - Note where the midterm is in the timeline. >> >> - "Get the code reviewed in week 11" is not good. You should be >> submitting your code for review whenever you have an atomic patch. >> Otherwise, you will develop a very large branch that will be very >> difficult for us to review, and it will be very likely to take a long >> time before it can get merged. Many GSoC students in the past have >> done this (myself included), and have had branches not merged for a >> long time as a result. >> >> Actually, I think this is something we need to make an extra effort to >> do better this year, so I'll start a new discussion on it. >> >> - As I've told all the other students so far, please include a list of >> your contributions to SymPy, so that we can see what you've done so >> far, and so that we know that you've completed the patch requirement. >> >> - Go ahead and submit this at google-melange.com. You will be able to >> modify it up to the deadline. This way, it will be there, so you >> won't have to worry if you have any issues as the deadline approaches. >> Also, it will allow the mentors to get a head start on privately >> reviewing your application, which help us tremendously. >> >> Aaron Meurer > > > Thanks, I was a bit sloppy out there. I have made the necessary > changes. >> >> On Fri, Mar 30, 2012 at 10:40 AM, Bharath M R <catchmrbhar...@gmail.com> >> wrote: >> > My GSoC Application can be found at >> > >> > https://github.com/sympy/sympy/wiki/GSoC-2012-Application--Bharath-M-R-:-Plotting-Module. >> > Can you please review the application and suggest any changes? >> > >> > Thanks, >> > Bharath M R >> >> > >> > >> >> >> > -- >> > You received this message because you are subscribed to the Google >> > Groups >> > "sympy" group. >> > To view this discussion on the web visit >> > https://groups.google.com/d/msg/sympy/-/viS6iaIBrWIJ. >> > >> > To post to this group, send email to sympy@googlegroups.com. >> > To unsubscribe from this group, send email to >> > sympy+unsubscr...@googlegroups.com. >> > For more options, visit this group at >> > http://groups.google.com/group/sympy?hl=en. > > -- > You received this message because you are subscribed to the Google Groups > "sympy" group. > To view this discussion on the web visit > https://groups.google.com/d/msg/sympy/-/1ViBNl1hWEkJ. > > To post to this group, send email to sympy@googlegroups.com. > To unsubscribe from this group, send email to > sympy+unsubscr...@googlegroups.com. > For more options, visit this group at > http://groups.google.com/group/sympy?hl=en. -- You received this message because you are subscribed to the Google Groups "sympy" group. To post to this group, send email to sympy@googlegroups.com. To unsubscribe from this group, send email to sympy+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sympy?hl=en.
