No problem. Just update your pull request and we will review it.
On 17.04.2012 14:35, Comer wrote:
Hi Tom, Thanks for making the point. I implemented your suggestion immediately. Sorry for not replying. Best, Comer On Saturday, April 14, 2012 10:47:47 AM UTC-4, Tom Bachmann wrote: Hi, the problem is that your addition of "dual_matrix" is too far down in the file. It is now defined as a global function to which one may pass a matrix. However, you want it as a method of the Matrix class. You could probably put it around line 3318, after the is_Identity method (and similarly aligned!). Best, Tom On 14.04.2012 15:22, Comer Duncan wrote: > Hi, > > Can someone please help me get past the following issue? > > I have added a new method to sympy/matrices/matrices.py to compute the > matrix dual of a given matrix. The name of the method is > dual_matrix(). I have added this method to my local copy of sympy > (test1) and have done a git add and git commit. I have also put a > test_dual_matrix function at the bottom of > sympy/matrices/tests/test_matrices.py. When I run test on the > matrices I get: > > [ComerMacPro:~/sympy] comerduncan% ./bin/test > sympy/matrices/tests/test_matrices.py > ============================= test process starts ============================== > executable: /usr/bin/python (2.7.1-final-0) > architecture: 64-bit > cache: yes > ground types: python > random seed: 54812667 > > sympy/matrices/tests/test_matrices.py[106] ...fffff............................. > ....................................................................E [FAIL] > > ________________________________________________________________________________ > ____________ sympy/matrices/tests/test_matrices.py:test_dual_matrix ____________ > File "/users/comerduncan/sympy/sympy/matrices/tests/test_matrices.py", > line 2221, in test_dual_matrix > assert F.dual_matrix() == Matrix( > ((0,B_x,B_y,B_z),(-B_x,0,E_z,-E_y),(-B_y,-E_z,0,E_x),(-B_z,E_y,-E_x,0)) > ) > File "/Users/comerduncan/sympy/sympy/matrices/matrices.py", line > 2953, in __getattr__ > raise AttributeError("Matrix has no attribute %s." % attr) > AttributeError: Matrix has no attribute dual_matrix. > > tests finished: 100 passed, 5 expected to fail, 1 exceptions, in 4.34 seconds = > DO *NOT* COMMIT! > > So, how come the new function dual_matrix is not seen? Is it the case > that when ./bin/test runs sympy/matrices/tests/test_matrices.py it > loads the system sympy rather than the local, in-directory sympy tree > and thus does not see any additional function(s) added at the end of > matrices.py? I am unsure about this, so I would appreciate some ideas > on what I can//should do. > > Thanks very much. > > Comer > -- You received this message because you are subscribed to the Google Groups "sympy" group. To view this discussion on the web visit https://groups.google.com/d/msg/sympy/-/eEM2f8rmMwEJ. To post to this group, send email to sympy@googlegroups.com. To unsubscribe from this group, send email to sympy+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sympy?hl=en.
-- You received this message because you are subscribed to the Google Groups "sympy" group. To post to this group, send email to sympy@googlegroups.com. To unsubscribe from this group, send email to sympy+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sympy?hl=en.