On 27.06.2012 02:28, Aaron Meurer wrote:
Yes, I think I will. I've already reviewed up to agca7
That's awesome, because you also looked at agca8 (documentation), and
that's everything! (I have agca9 and probably also agca10 in the queue,
and also quite a lot more further plans than time; but in any case
things will slow down now.)
so if all my
comments have been addressed and tests pass, it can be merged (Tom
will have to be the judge of the first point).
The tests for agca8:
http://travis-ci.org/#!/sympy/sympy/builds/1708779
and for trigsimp-groebner:
http://travis-ci.org/#!/sympy/sympy/builds/1708595
[all pass, which means 2.5 - 2.7 and 3.2].
This is with travis. The sympy-bot seems to have hash randomization
enabled, which apparently breaks things all over the place.
I have addressed all comments, except for the ones I outlined in the
original mail with this title. My feelings here are:
regarding homomorphism printing: wait until matrix is changed, then
adapt in a similar way (as you suggested)
regarding automatic coercion: I like having rather more than less of it.
Thus I vote for leaving it in.
regarding class names: If you think this is a dealbreaker, I am happy to
rename to a still longer name; IMHO that's not terribly much use. (The
actual class names are "internal" anyway, so proper clients should not
be broken by renaming.)
--
You received this message because you are subscribed to the Google Groups
"sympy" group.
To post to this group, send email to sympy@googlegroups.com.
To unsubscribe from this group, send email to
sympy+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/sympy?hl=en.
