On Feb 8, 2013, at 3:01 PM, David Joyner <wdjoy...@gmail.com> wrote: On Mon, Jan 28, 2013 at 6:05 PM, Aaron Meurer <asmeu...@gmail.com> wrote:
... For the codes, I'm not sure. "combinatorics" already contains a bunch of stuff that isn't really combinatorics (like group theory). Maybe we should create "algebra" and put it and group theory there. You This sounds reasonable to me. I'm not sure of the process for moving things around. will have a better idea than I about where the best place to put things is, since you know what things will do. We definitely welcome the contribution, regardless of where it ends up. I am actually taking a course in algebraic geometry and codes this semester, focusing on error-correcting codes, so maybe this will be useful to me (or maybe not, it sounds like you are focusing more on cryptography than codes). I should write up coding theory stuff as well. But for now, it is pure (basic, elementary) crypto. ... Also, you could try using FF (like FF(3)(1) for 1 mod 3). It seems to work in my tests. You'll more likely than not want to use FF(3, symmetric=False) to avoid "negative" numbers. I forgot to do that. It seems to be okay though. I posted a first version to http://boxen.math.washington.edu/home/wdj/teaching/crypto0.py Place it in sympy-0.7.1/sympy and all the examples should work. I am unsure of a few things. (a) Is the docstring formatting okay? They need to be formatted with underlined headers so that they will be rendered correctly in Sphinx. See other parts of SymPy for examples. Also https://github.com/sympy/sympy/wiki/Writing-documentation. (b) Are there enough examples? Documentation that is not in docstrings should be moved to some rst file in doc/. I think the examples are fine, but you also need tests. (c) Is the snippet "unique" at the bottom of the file allowed in SymPy? (I found it somewhere and don't know the copyright or license. It's a one-liner and thus might not be copyrightable.) I think it's fine. We might even already have something like that if you search the code base. Other issues? Can you submit this as a pull request? Aaron Meurer Aaron Meurer - David -- You received this message because you are subscribed to the Google Groups "sympy" group. To post to this group, send email to sympy@googlegroups.com. To unsubscribe from this group, send email to sympy+unsubscr...@googlegroups.com. Visit this group at http://groups.google.com/group/sympy?hl=en. For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and stop receiving emails from it, send an email to sympy+unsubscr...@googlegroups.com. To post to this group, send email to sympy@googlegroups.com. Visit this group at http://groups.google.com/group/sympy?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
