You should just push the changes. Then I can look over the code compared to the pseudocode in Bronstein and see if you did it right.
Aaron Meurer On Fri, Mar 7, 2014 at 5:54 PM, Anurag Sharma <anurag...@gmail.com> wrote: > <https://lh3.googleusercontent.com/-5WCvCIA2ngA/Uxpbxt9uOKI/AAAAAAAAALc/DK48f1fjAEU/s1600/Screenshot+from+2014-03-08+05%3A21%3A21.png> > Okay as of now. Chetna's branch passes all the tests. I have tried to make > some changes where I dont harcode the value of a. But it invariably fails > the tests. And all the tests fail at the same point. > As shown in the iamge attached. What I have basically done is to remove > the harcoded '-1' and put 'a' in place of that. > I am resisting to push these changes. So I'd be really glad if some one > can discuss over this with me here or on irc. > In the meanwhile kindly review the PR. > > > > On Friday, March 7, 2014 11:36:40 PM UTC+5:30, Anurag Sharma wrote: >> >> Improved the efficiency of order_at in rde.py. >> Kindly review that. >> There is also an issue that I have contributed to the branch that Chetna >> was working on. Now till her branch is not merged my these changes wont get >> merged. I'm trying to fix loose ends in her PR with her help in the >> meanwhile. Is there any workaround this ? >> >> Cheers >> Anurag >> >> >> On Tuesday, March 4, 2014 1:26:53 AM UTC+5:30, Anurag Sharma wrote: >>> >>> Thanks for the links Roaul and Aaron. >>> I'll look at them and tell you the progresss report after thursday. >>> I have an exam in the interim. (Master's course which I foolishly took >>> :P :( ) >>> >>> Anurag >>> >>> On Sunday, March 2, 2014 6:35:25 AM UTC+5:30, rl wrote: >>>> >>>> Hi, >>>> >>>> > And even if we implement all of Bronstein's book, there is a lot of >>>> > further potential work. Bronstein's book only covers the >>>> > transcendental case, but there are also the algebraic and mixed >>>> cases. >>>> >>>> For the mixed case one maybe should look at: >>>> >>>> "Mixed Transcendental and Algebraic Extensions for the Risch-Norman >>>> Algorithm"" >>>> >>>> by Stefan Böttner. However I could not obtain a copy of this work yet. >>>> >>> -- > You received this message because you are subscribed to the Google Groups > "sympy" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to sympy+unsubscr...@googlegroups.com. > To post to this group, send email to sympy@googlegroups.com. > Visit this group at http://groups.google.com/group/sympy. > To view this discussion on the web visit > https://groups.google.com/d/msgid/sympy/67e0c80d-65c6-4693-9081-a57963886c4b%40googlegroups.com<https://groups.google.com/d/msgid/sympy/67e0c80d-65c6-4693-9081-a57963886c4b%40googlegroups.com?utm_medium=email&utm_source=footer> > . > > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and stop receiving emails from it, send an email to sympy+unsubscr...@googlegroups.com. To post to this group, send email to sympy@googlegroups.com. Visit this group at http://groups.google.com/group/sympy. To view this discussion on the web visit https://groups.google.com/d/msgid/sympy/CAKgW%3D6LZiCqDnMjS8yenD3uoVjmn7NoJu4MmjoF9%3DY%2BPbSkVQw%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
