Am 07.01.2015 um 14:51 schrieb Sergey Kirpichev:
If we can first add a test for this in the code quality module - I'm +1.
I'm not sure that that is possible.
Also, I'd want to run the test just locally, and push the fixes, before
adding the tests to the code quality module.
With any other order, the next person to git pull will get a nasty
surprise: all their bin/test runs will fail with those newly tested-for
errors, so they can't rely on that "I can make the PR as soon as all
tests pass" rule anymore.
However, I'd also like to know if such fixes are acceptable if it turns
out we can't make it an automated test. It's still an improvement, even
if it won't be long-lived - I could use that at leasts for my upcoming
work on getting rid of the C class.
--
You received this message because you are subscribed to the Google Groups
"sympy" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to sympy+unsubscr...@googlegroups.com.
To post to this group, send email to sympy@googlegroups.com.
Visit this group at http://groups.google.com/group/sympy.
To view this discussion on the web visit
https://groups.google.com/d/msgid/sympy/54AD5140.5080907%40durchholz.org.
For more options, visit https://groups.google.com/d/optout.
